Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise on non-existing locale #2319

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Apr 26, 2022

If a locale parameter is given, we want to give a good error and not
render the default locale.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

If a locale parameter is given, we want to give a good error and not
render the default locale.
@mamhoff mamhoff force-pushed the raise-on-wrong-locale branch 2 times, most recently from 9bc4a16 to c14f65d Compare April 26, 2022 10:47
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@tvdeyen tvdeyen enabled auto-merge April 26, 2022 10:55
@tvdeyen tvdeyen merged commit 443ee33 into AlchemyCMS:main Apr 26, 2022
tvdeyen added a commit that referenced this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants