Set preview mode earlier #2307
Merged
Set preview mode earlier #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `OnPageLayout` callbacks, it's probably wise to have `@version` available for choosing draft or public versions of pages (e.g. when loading a referenced page via the `Alchemy::Ingredient::Page`).
It's useful to have not just the page, but also the page version available in `OnPageLayout` callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This sets
@preview_modebefore executing anyOnPageLayoutcallbacks, so that the callbacks can identify whether they are in in preview mode or not.Notable changes (remove if none)
This just changes the order of callbacks.
Checklist