Fix updating the public_on date on persisted pages #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
fix-setting-public-on-date
branch
3 times, most recently
from
b05cdb3
to
26e92bc
Compare
tvdeyen
reviewed
Apr 21, 2022
When updating a page's `public_on` date, we need to save the associated public page as well. This commit accomplishes that. Prior to this commit, we would set the `public_on` date on the public version, but not persist it.
mamhoff
force-pushed
the
fix-setting-public-on-date
branch
from
26e92bc
to
dcb6a05
Compare
tvdeyen
added a commit
that referenced
this pull request
Apr 26, 2022
Fix updating the public_on date on persisted pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a page's
public_ondate, we need to save the associatedpublic page as well. This commit accomplishes that.
Prior to this commit, we would set the
public_ondate on the publicversion, but not persist it.
Checklist