Restrict Node select to the site/language of the page being edited

[dbwinger]

What is this pull request for?

Restrict Node results to the current Site/Language in the EssenceNode editor.

Checklist

• I have followed Pull Request guidelines
• I have added a detailed description into each commit message
• I have added tests to cover this change

[tvdeyen]

I am not sure we want that as a default. There is the query_params feature you could use for this.

[dbwinger]

I am not sure we want that as a default. There is the query_params feature you could use for this.

If we don't want it as the default, are you suggesting that we add the language_id in the element definition under settings -> query_params? Since the element definitions aren't evaluated during runtime, and therefore we can't include the actual current language of the request there, I suppose we could use something like the string 'current' in that setting to indicate the current language should be used? Also, everything in query_params ends up in the filter param, which currently gets fed to @nodes.ransack, which I don't believe expects a parameter like language_id.

Am I misunderstanding your suggestion or the code?

[tvdeyen]

I am not sure we want that as a default. There is the query_params feature you could use for this.

If we don't want it as the default, are you suggesting that we add the language_id in the element definition under settings -> query_params? Since the element definitions aren't evaluated during runtime, and therefore we can't include the actual current language of the request there, I suppose we could use something like the string 'current' in that setting to indicate the current language should be used? Also, everything in query_params ends up in the filter param, which currently gets fed to @nodes.ransack, which I don't believe expects a parameter like language_id.

Am I misunderstanding your suggestion or the code?

You are right. This is not possible right now. Very tricky situation. I am currently a bit hesitant about restricting this, but maybe these are edge cases. Who wants to link display a menu of a foreign language? @mamhoff @robinboening wdyt?

[robinboening]

I am currently a bit hesitant about restricting this, but maybe these are edge cases. Who wants to link display a menu of a foreign language?

It does sound like an edge case to me and I don't see why anyone wanted to render a menu of another language. I could rather see how one could make a case where they want to render a menu of another site (same language) though. Still an edge case.

I don't see this restriction as a bad thing, but let me ask you if/how the benefits of the restriction outweigh the loss of flexibility?

[tvdeyen]

It does sound like an edge case to me and I don't see why anyone wanted to render a menu of another language. I could rather see how one could make a case where they want to render a menu of another site (same language) though. Still an edge case.

Another site is another language. Even if the name is the same, the language id is different.

[robinboening]

It does sound like an edge case to me and I don't see why anyone wanted to render a menu of another language. I could rather see how one could make a case where they want to render a menu of another site (same language) though. Still an edge case.

Another site is another language. Even if the name is the same, the language id is different.

Technically, yes. But from a less technical editor's perspective english is english. However, it would still be an edge case and right now a very theoretical one. So I think the suggested scopes ain't bad.

[tvdeyen]

Ok, let's go with it.