Fix new Sitemap #2262
Merged
Fix new Sitemap #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A little convenience
Webservers do not all understand the PATCH, and PUT HTTP verbs. Nginx must be compiled with support for it. Since we cannot know if the web server has been configured as such, we need to do what Rails does: Send a _method override.
Our ajax lib takes care of sending the CSRF token and works with old Webservers that do not support PATCH HTTP verb.
mamhoff
approved these changes
Mar 18, 2022
tvdeyen
added a commit
that referenced
this pull request
Mar 18, 2022
Backport pull request #2262 from tvdeyen/fix-sitemap
v-ruiz
added a commit
to v-ruiz/alchemy_cms
that referenced
this pull request
Mar 21, 2022
Fix new Sitemap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Use our
ajaxlib over browsersfetch.Our
ajaxlib takes care of sending the CSRF token and now also works with old Webservers that do not support PATCH HTTP verb.Notable changes
Webservers do not all understand the PATCH, and PUT HTTP verbs.
Nginx must be compiled with support for it.
Since we cannot know if the web server has been configured as such,
we need to do what Rails does: Send a
_methodoverride.Screenshots
Remove if no visual changes have been made.
Checklist