Allow parent page change #2246
Merged
Allow parent page change #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
allow-parent-page-change
branch
from
278b7bf
to
b9c374a
Compare
tvdeyen
force-pushed
the
allow-parent-page-change
branch
from
b9c374a
to
35ef102
Compare
This is useful for large sites with many pages
Sometimes we do not want to allow to clear the selection.
tvdeyen
force-pushed
the
allow-parent-page-change
branch
from
35ef102
to
55c42f2
Compare
Unless the page is the current language root or a layoutpage, we allow to change the parent. This is much more efficient than using the dragndrop interface, especially in large trees.
A page needs a parent, unless it is the root page, but this does not get created in this dialog.
This is more reliable than just replacing the old and the new parents
tvdeyen
force-pushed
the
allow-parent-page-change
branch
from
55c42f2
to
5ecdf46
Compare
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
Mar 9, 2022
Backport pull request AlchemyCMS#2246 from tvdeyen/allow-parent-page-change
tvdeyen
added a commit
that referenced
this pull request
Mar 9, 2022
Backport pull request #2246 from tvdeyen/allow-parent-page-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Unless the page is the current language root or a layoutpage, we allow to change the parent.
This is much more efficient than using the dragndrop interface, especially in large trees.
Notable changes
The new page form now uses the
alchemyPageSelect. This is useful for large sites with many pages.Screenshots
Remove if no visual changes have been made.
Checklist
TODO