Touch nodes and all ancestors on page update #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
touch-nodes-on-page-update
branch
from
bf7ee77
to
7a64d48
Compare
|
Test errors seam unrelated. Investigating. |
tvdeyen
force-pushed
the
touch-nodes-on-page-update
branch
2 times, most recently
from
51995c6
to
bb8030c
Compare
tvdeyen
force-pushed
the
touch-nodes-on-page-update
branch
2 times, most recently
from
850cbbe
to
c08916d
Compare
Menu partials might be cached. So we need to make sure the menu node a page might be attached to and all their ancestors get touched as well. Closes AlchemyCMS#2080
tvdeyen
force-pushed
the
touch-nodes-on-page-update
branch
from
c08916d
to
98a2053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Menu partials might be cached.
So we need to make sure the menu node a page might be attached to and all their ancestors get touched as well.
Closes #2080
Checklist