fix(ImageCropper): Add dom ids to picture crop fields #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These DOM ids have been removed in cb49ce8 to remove duplicated DOM ids. But we need DOM ids for the image cropper to work. Fixed by adding unique DOM ids for these fields. Closes AlchemyCMS#2216
tvdeyen
force-pushed
the
2216-fix-image-cropper
branch
from
c2c2dd0
to
d629309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
These DOM ids have been removed in cb49ce8 to remove duplicated DOM ids.
But we need DOM ids for the image cropper to work.
Fixed by adding unique DOM ids for these fields.
Closes #2216
Checklist