-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #2101 #2202
Closed
Closed
Fix issue #2101 #2202
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
48ebbfa
pass new parent id to child
juryghidinelli eedb26d
test fix
juryghidinelli f63bcba
Merge branch 'fix_tree_copy_error' into main
juryghidinelli 11c7c46
code style corrections
juryghidinelli fc8341c
another one code style corrections
juryghidinelli 3aa7765
last one style correction
juryghidinelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
code style corrections
- Loading branch information
commit 11c7c468c0f9b6f0cfd47698e389d2f7eec8e09e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -765,7 +765,7 @@ class AnotherUrlPathClass; end | |
subject { source.copy_children_to(new_parent) } | ||
|
||
it "should copy the source page with the given name to the new parent" do | ||
child = mock_model("Page",children:[]) | ||
child = mock_model("Page", children: []) | ||
new_child = mock_model("Page") | ||
|
||
expect(new_child).to receive(:move_to_child_of).with(new_parent) | ||
|
@@ -774,12 +774,11 @@ class AnotherUrlPathClass; end | |
expect(Page).to receive(:copy).with(child, { | ||
parent_id: new_parent.id, | ||
language_id: new_parent.language_id, | ||
language_code: new_parent.language_code | ||
language_code: new_parent.language_code, | ||
}).and_return(new_child ) | ||
subject | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of testing the implementation we should test the result. For that we need to create a page with children and verify the children end up on the new parent. That way we can check if the issue is actually in the missing |
||
end | ||
|
||
|
||
end | ||
|
||
describe "#public_version" do | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should already be handled by
move_to_child
of. Alsomove_to_child
sets the appropriatelft
andrgt
values the nested set needs.