Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datepicker simple form input #2162

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 14, 2021

What is this pull request for?

Alchemy has a nice datepicker build on top of flatpickr.
Setting it up is a bit tedious. We have several form helpers,
but not a simple form input.

Now we have

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Alchemy has a nice datepicker build on top of flatpickr.
Setting it up is a bit tedious. We have several form helpers,
but not a simple form input.

Now we have
@tvdeyen tvdeyen added this to the 6.0 milestone Jul 14, 2021
@tvdeyen tvdeyen requested a review from a team July 14, 2021 09:19
Copy link
Contributor

@robinboening robinboening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I don't have any change requests.

Only a tiny nit picky comment about the specs: I personally don't like the use of subject so much and prefer repeating the code line in the example (I find myself jumping back and forth in the file, not being able to focus on where I am reading the code). I am not asking to change it.

@tvdeyen tvdeyen merged commit 388298e into AlchemyCMS:main Jul 14, 2021
@tvdeyen tvdeyen deleted the datepicker-input branch July 14, 2021 10:28
@tvdeyen
Copy link
Member Author

tvdeyen commented Jul 14, 2021

Looks great! I don't have any change requests.

Only a tiny nit picky comment about the specs: I personally don't like the use of subject so much and prefer repeating the code line in the example (I find myself jumping back and forth in the file, not being able to focus on where I am reading the code). I am not asking to change it.

Fair enough. This is a general discussion about test style. I think both is fine. Whatever it takes to write specs at all 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants