Add element groups functionality for cleaning up editors

[dbwinger]

What is this pull request for?

Adds ability to group contents/ingredients in element editors to clean up/organize elements with large numbers of contents.

Notable changes (remove if none)

Adds a group option to contents or ingredients entries in elements.yml.

Screenshots

When elements.yml contains:

- name: example_element
  contents:
  - name: ungrouped_content
    type: EssenceText
  - name: group_1_content_1
    type: EssenceText
    group: group 1
  - name: group_1_content_2
    type: EssenceText
    group: group 1
  - name: group_2_content_1
    type: EssenceText
    group: group 2
  - name: group_2_content_2
    type: EssenceText
    group: group 2
  - name: another_ungrouped_content
    type: EssenceText

Element editor will look like this (after clicking on "Group 1" to expand):

Checklist

• I have followed Pull Request guidelines
• I have added a detailed description into each commit message
• I have added tests to cover this change

[dbwinger]

NOTE, I haven't yet added tests, and I'm guessing the UI should be cleaned up a bit. I wanted to get feedback on whether this is a feature that might be accepted before I polish everything up.

[gr8bit]

Do the groups support translations for their names?

[tvdeyen]

I like the feature. But think we can improve it a bit more. Translated group names are mandatory. Also try to make use of the collection rendering and the Element and Content editor presenter classes.

Thanks for the contribution. It's really appreciated

[dbwinger]

Good call on translations and collection rendering. Updates coming soon.

[github-actions]

This pull request has not seen any activiy in a long time.
Probably because of missing tests or a necessary rebase.
This PR will be closed in 7 days if no further activity happens.

[tvdeyen]

@dbwinger any change for an update?

[dbwinger]

@dbwinger any change for an update?

No change or update. It's still on my TODO list. Looking back over it now, I think I'll be able to get it updated and ready for another review next week.

[dbwinger]

@tvdeyen Can you help me know what should be tested for this change? I see that IngredientEditor#translated_role is not tested, probably because it's just a call to Alchemy.t which is tested elsewhere, so I assume there's no need to add tests for my added ElementEditor#translated_group. I plan to some specs related to the ingredient/content groups' UI in edit_elements_feature_spec.rb. Let me know if anything else ought to have tests.

[tvdeyen]

Very nice. Thank you 🙏🏻

I have a little nit pick because of blank/present. They are costly and unnecessary.

I will try to have a look at the UI today

Really like that feature. Thanks for collaborating

[tvdeyen]

I still need to look into the UI. On my list

[tvdeyen]

@dbwinger I adjusted some styles. It now looks like this

Working with this a bit more today, I found it irritating that groups are always collapsed. Expanded groups collapse after reload. I don't want to add persistence, but maybe we can safe the state in the session at least.

[dbwinger]

Working with this a bit more today, I found it irritating that groups are always collapsed. Expanded groups collapse after reload. I don't want to add persistence, but maybe we can safe the state in the session at least.

Good idea. I just took a crack at that.

[dbwinger]

@tvdeyen I don't mean to nag, but just thought I'd check in on this and make sure you're not waiting on me for anything.

[tvdeyen]

@tvdeyen I don't mean to nag, but just thought I'd check in on this and make sure you're not waiting on me for anything.

No, I am not waiting. The feature is done if it's done. Take your time.

[dbwinger]

@tvdeyen I don't mean to nag, but just thought I'd check in on this and make sure you're not waiting on me for anything.

I'm not sure if I communicated effectively. I meant by this that as far as I can tell, it's "done" and ready for your review.

[tvdeyen]

Didn't saw the latest commit. This looks great. Thanks