Trigger publish targets after page published #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 6.0.3.7 includes a security fix that forces us to use Symbols in polymorphic routes.
Publishing pages runs as active jobs. The published page trigger we send to registered publish_targets need to be send after the page has been published in order to prevent race conditions.
tvdeyen
force-pushed
the
trigger-publish-targets-after-page-published
branch
from
b1fde00
to
5248706
Compare
mamhoff
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Publishing pages runs as active jobs. The published page trigger
we send to registered publish_targets need to be send after the
page has been published in order to prevent race conditions.
Checklist