Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page versioning issues #2076

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Fix page versioning issues #2076

merged 4 commits into from
Apr 21, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 21, 2021

What is this pull request for?

Read the descriptive commit messages

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

If we don't Rails is not able to autoload the constant.
We do not must have another draft version
if there is already one.
We do not want to have orphaned records
if something down the line happens
When the public_on is set to an empty string (from a form field)
we must not create a new draft version if there is not also a public version.
@tvdeyen tvdeyen added this to the 6.0 milestone Apr 21, 2021
Copy link
Contributor

@pelargir pelargir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@tvdeyen tvdeyen merged commit 89c0938 into AlchemyCMS:main Apr 21, 2021
@tvdeyen tvdeyen deleted the fix-page-issues branch April 21, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants