Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle json requests in error handler #2071

Merged
merged 2 commits into from
Apr 17, 2021
Merged

Handle json requests in error handler #2071

merged 2 commits into from
Apr 17, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 17, 2021

What is this pull request for?

Handles json requests in error handler.

Returns a object with error message for JSON requests.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen
Handle json requests in error handler
1469a53 
Returns a object with error `message` for JSON requests.
@tvdeyen tvdeyen added this to the 6.0 milestone Apr 17, 2021
@tvdeyen
Return elements in api controller ordered by position
7796ea1 
This would be expected anyway and fixes a flaky sepc.
mamhoff
mamhoff approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Also the fix for that flaky spec, thank you!

@tvdeyen tvdeyen merged commit ed99394 into AlchemyCMS:main Apr 17, 2021
@tvdeyen tvdeyen deleted the handle-json-requests-in-error-handler branch April 17, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @mamhoff