Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch Elements only after update #2062

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Apr 9, 2021

What is this pull request for?

When an essence has a related object, such as a picture or an
attachment, we need to break caches when that related object changes.
This reflects this desire - but stops touching the elements on first
creation. This results in a major speedup when publishing pages, as
publishing results in a lot of essence and element creation.

Notable changes (remove if none)

None, I believe.

Checklist

When an essence has a related object, such as a picture or an
attachment, we need to break caches when that related object changes.
This reflects this desire - but stops touching the elements on first
creation. This results in a major speedup when publishing pages, as
publishing results in a lot of essence and element creation.
@tvdeyen tvdeyen self-requested a review April 9, 2021 11:08
@tvdeyen tvdeyen added this to the 6.0 milestone Apr 9, 2021
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is really good and never made any sense, as attachments and pictures get created way ahead of time :)

@tvdeyen tvdeyen merged commit 343cc8a into AlchemyCMS:main Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants