Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add nested element with multiple nestable elements #2052

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 24, 2021

What is this pull request for?

If an element allows multiple nestable elements the element select dialog appears. That form was missing the page_version.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

So that it actually tests what it does:
Immediately creating a nested element.

Also add a pending spec for creating a nested element for
element having multiple nestable elements.
If an element allows multiple nestable elements the element select
dialog appears. That was missing the page_version.
@tvdeyen tvdeyen requested a review from mamhoff March 24, 2021 08:12
@tvdeyen tvdeyen added this to the 6.0 milestone Mar 24, 2021
@tvdeyen tvdeyen merged commit 390205f into AlchemyCMS:main Mar 24, 2021
@tvdeyen tvdeyen deleted the fix/create-nested-element branch March 24, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants