Fix jpeg quality option for jpeg files #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kulturbande Thanks. This is really great 👏🏻 The latest |
|
@kulturbande please rebase your branch with latest |
|
@kulturbande also please use the PR description as commit description, since it's usefull information that we want to have in the commit history. |
The quality option was previously ignored if the image was a JPEG. Now the quality configuration will be added if the file isn't a JPEG or the quality option was set.
tvdeyen
force-pushed
the
bugfix/jpeg_quality
branch
from
48206d8
to
7ad0006
Compare
tvdeyen
changed the title
tvdeyen
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
@kulturbande thanks. I added specs and rebased with latest main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The quality option was previously ignored, if the image was a JPEG. Now the quality configuration will be added, if the file isn't a JPEG or the quality - option was set.
Checklist