Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Ransack to below 2.4.2 #2012

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Pin Ransack to below 2.4.2 #2012

merged 1 commit into from
Jan 29, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 29, 2021

What is this pull request for?

They dropped Ruby 2.5 support in a patch level release. Since we still support Ruby 2.5 and will remove it in the next major release we need to pin Ransack to the last version that still supports Ruby 2.5

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

They dropped Ruby 2.5 support in a patch level release.
Since we still support Ruby 2.5 and will remove it in the
next major release we need to pin Ransack to the last version
that still supports Ruby 2.5
@tvdeyen tvdeyen added this to the 5.2 milestone Jan 29, 2021
@tvdeyen tvdeyen merged commit 8b5f193 into AlchemyCMS:main Jan 29, 2021
@tvdeyen tvdeyen deleted the pin-ransack branch January 29, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants