Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy element feature (5.1) #1998

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 12, 2021

What is this pull request for?

Same as #1996 but for the 5.1-stable branch

With the introduction of the Element Editor decorator this feature broke.

Instead of using the class of the element_editor local variable we use the remarkable type string that we exactly know in this case.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

With the introduction of the Element Editor decorator this
feature broke.

Instead of using the class of the element_editor local variable
we use the remarkable type string that we exactly know in this case.
@tvdeyen tvdeyen requested a review from mamhoff January 12, 2021 12:44
@tvdeyen tvdeyen changed the title Fix copy element feature Fix copy element feature (5.1) Jan 12, 2021
@tvdeyen tvdeyen merged commit 7ff4579 into AlchemyCMS:5.1-stable Jan 12, 2021
@tvdeyen tvdeyen deleted the fix-element-copy-5.1 branch January 12, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant