Allow Element and Content deprecation notices #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
element-deprecations
branch
from
0a8c1ea
to
4e5b1b2
Compare
Elements can be marked as deprecated. They will be visually displayed with a warning. The deprecation notice can be localized.
Contents can be marked as deprecated. They will be visually displayed with a warning. The deprecation notice can be localized.
tvdeyen
force-pushed
the
element-deprecations
branch
from
4e5b1b2
to
80ad24c
Compare
This way it does not conflict with warnings that might be displayed as well and it aligns nicely with the essence boolean
It now uses the content_editor decorator that has two new methods to display warnings.
tvdeyen
changed the title
|
This works quite well. Nice work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Elements and Contents can be marked as deprecated.
They will be visually displayed with a warning. The deprecation notice can be localized.
This also changes the position of the content hint icon.
Screenshots
Checklist