Deprecate elements fallbacks #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
deprecate-elements-fallbacks
branch
2 times, most recently
from
56061e7
to
cdb97a5
Compare
Providing fallback to render_elements or the ElementsFinder class will be removed from Alchemy 6.0
Passing a String to `render_elements` `from_page` option will not be supported anymore in Alchemy 6. Please load the page beforehand and pass it as object instead.
tvdeyen
force-pushed
the
deprecate-elements-fallbacks
branch
from
cdb97a5
to
68da3c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Providing
fallbacktorender_elementsor theElementsFinderclass will be removed from Alchemy 6.0render_elementsfrom_pagePassing a String to
render_elementsfrom_pageoption will not be supported anymore in Alchemy 6. Please load the page beforehand and pass it as object instead.Checklist