Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move back to Travis CI #1907

Merged
merged 7 commits into from
Jul 26, 2020
Merged

Move back to Travis CI #1907

merged 7 commits into from
Jul 26, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 25, 2020

This reverts commit 411fc9d.

What is this pull request for?

Describe you pull request here...

Closes # (Remove if not related to any issue)

Notable changes (remove if none)

Explain any changes (maybe breaking?) that have been made.

Screenshots

Remove if no visual changes have been made.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen self-assigned this Jul 25, 2020
@tvdeyen tvdeyen force-pushed the back-to-travis branch 3 times, most recently from ed57406 to 2154e1f Compare July 25, 2020 23:09
@tvdeyen tvdeyen force-pushed the back-to-travis branch 7 times, most recently from 5b9c33f to cdb19f2 Compare July 26, 2020 18:28
This with all supported Ruby and Rails versions
It is not trivial to merge the coverage with the RSpec coverage. Since we do not have much Jest specs yet, it is not worth it in the moment.
We do not test generators and after we moved the generators out of the lib/rails folder we need to adjust the filter.
@tvdeyen tvdeyen merged commit 0ceca4c into AlchemyCMS:master Jul 26, 2020
@tvdeyen tvdeyen deleted the back-to-travis branch July 26, 2020 18:52
tvdeyen added a commit that referenced this pull request Sep 29, 2020
* Move back to Travis CI

This reverts commit 411fc9d.

* Update codeclimate_test_reporter in travis.yml

* Remove warnings from travis.yml

* Update travis build matrix

This with all supported Ruby and Rails versions

* Set up travis jobs for rspec and jest specs

* Skip coverage upload for Jest specs

It is not trivial to merge the coverage with the RSpec coverage. Since we do not have much Jest specs yet, it is not worth it in the moment.

* Adjust rails generators coverage filter

We do not test generators and after we moved the generators out of the lib/rails folder we need to adjust the filter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant