Deprecate Attachment#urlname #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And deprecate urlname, because it is a not very well known name.
tvdeyen
force-pushed
the
deprecate-attachment-urlname
branch
from
7253523
to
09eb7c4
Compare
tvdeyen
changed the title
tvdeyen
changed the title
mamhoff
approved these changes
Jul 17, 2020
tvdeyen
added a commit
that referenced
this pull request
Jul 17, 2020
And deprecate urlname, because it is a not very well known name.
bichinger-stm
added a commit
to bichinger/alchemy_cms
that referenced
this pull request
Jul 17, 2020
…hemy_cms into active-storage-integration * 'active-storage-integration' of github.com:bichinger/alchemy_cms: v5.0.0 Do not convert JPEG images into JPG (AlchemyCMS#1904) Do not enable image cropper if file is missing (AlchemyCMS#1903) Always show original image as zoomed image (AlchemyCMS#1902) Rename Attachment#urlname into slug (AlchemyCMS#1848) Deprecate toolbar helper Bump version to 5.0.0.rc2 Fix tag-list height Fix vertical position of site name in page tab Allow editing sites Fix missing help_text_text translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Deprecate
Attachment#urlnameand use slug instead.urlnameis a strange term. We should use the common name.Checklist