Always create nested urls

app/models/alchemy/page.rb

@@ -428,7 +428,7 @@ def publish!
     def update_node!(node)
       hash = { lft: node.left, rgt: node.right, parent_id: node.parent, depth: node.depth, restricted: node.restricted }
 
-      if Config.get(:url_nesting) && urlname != node.url
+      if urlname != node.url
         LegacyPageUrl.create(page_id: id, urlname: urlname)
         hash[:urlname] = node.url
       end

app/models/alchemy/page/page_naming.rb

@@ -24,8 +24,7 @@ module Page::PageNaming
       after_update :update_descendants_urlnames,
         if: :should_update_descendants_urlnames?
 
-      after_move :update_urlname!,
-        if: -> { Config.get(:url_nesting) }
+      after_move :update_urlname!
     end
 
     # Returns true if name or urlname has changed.
@@ -64,8 +63,6 @@ def visible_ancestors
     private
 
     def should_update_descendants_urlnames?
-      return false if !Config.get(:url_nesting)
-
       saved_change_to_urlname? || saved_change_to_visible?
     end
 
@@ -76,14 +73,9 @@ def update_descendants_urlnames
 
     # Sets the urlname to a url friendly slug.
     # Either from name, or if present, from urlname.
-    # If url_nesting is enabled the urlname contains the whole path.
+    # The urlname contains the whole path including parent urlnames.
     def set_urlname
-      if Config.get(:url_nesting)
-        value = slug
-      else
-        value = urlname
-      end
-      self[:urlname] = nested_url_name(value)
+      self[:urlname] = nested_url_name(slug)
     end
 
     def set_title
@@ -110,9 +102,9 @@ def nested_url_name(value)
 
     # Slugs of all visible/non-language_root ancestors.
     # Returns [], if there is no parent, the parent is
-    # the root page itself, or url_nesting is off.
+    # the root page itself.
     def ancestor_slugs
-      return [] if !Config.get(:url_nesting) || parent.nil?
+      return [] if parent.nil?
 
       visible_ancestors.map(&:slug).compact
     end

lib/alchemy/config.rb

@@ -8,8 +8,10 @@ class << self
       # @param name [String]
       #
       def get(name)
+        check_deprecation(name)
         show[name.to_s]
       end
+
       alias_method :parameter, :get
 
       # Returns a merged configuration of the following files
@@ -25,6 +27,13 @@ def show
         @config ||= merge_configs!(alchemy_config, main_app_config, env_specific_config)
       end
 
+      # A list of deprecated configurations
+      # a value of nil means there is no new default
+      # any not nil value is the new default
+      def deprecated_configs
+        {}
+      end
+
       private
 
       # Alchemy default configuration
@@ -60,6 +69,20 @@ def merge_configs!(*config_files)
         config_files.each { |h| config.merge!(h.stringify_keys!) }
         config
       end
+
+      def check_deprecation(name)
+        if deprecated_configs.key?(name.to_sym)
+          config = deprecated_configs[name.to_sym]
+          if config.nil?
+            Alchemy::Deprecation.warn("#{name} configuration is deprecated and will be removed from Alchemy 5.0")
+          else
+            value = show[name.to_s]
+            if value != config
+              Alchemy::Deprecation.warn("Setting #{name} configuration to #{value} is deprecated and will be always #{config} in Alchemy 5.0")
+            end
+          end
+        end
+      end
     end
   end
 end

spec/controllers/alchemy/pages_controller_spec.rb

@@ -32,7 +32,7 @@ module Alchemy
         it "returns a 404" do
           expect { get(:index) }.to raise_exception(
             ActionController::RoutingError,
-           'Alchemy::Page not found "/"',
+            'Alchemy::Page not found "/"',
           )
         end
       end
@@ -153,12 +153,12 @@ module Alchemy
           end
 
           it "loads the root page of that language" do
-            get :index, params: {locale: "en"}
+            get :index, params: { locale: "en" }
             expect(assigns(:page)).to eq(start_page)
           end
 
           it "sets @root_page to root page of that language" do
-            get :index, params: {locale: "en"}
+            get :index, params: { locale: "en" }
             expect(assigns(:root_page)).to eq(start_page)
           end
         end
@@ -173,7 +173,7 @@ module Alchemy
 
         it "renders 404" do
           expect {
-            get :show, params: {urlname: not_yet_public.urlname}
+            get :show, params: { urlname: not_yet_public.urlname }
           }.to raise_error(ActionController::RoutingError)
         end
       end
@@ -188,7 +188,7 @@ module Alchemy
 
         it "renders 404" do
           expect {
-            get :show, params: {urlname: no_longer_public.urlname}
+            get :show, params: { urlname: no_longer_public.urlname }
           }.to raise_error(ActionController::RoutingError)
         end
       end
@@ -202,7 +202,7 @@ module Alchemy
         end
 
         it "renders page" do
-          get :show, params: {urlname: still_public_page.urlname}
+          get :show, params: { urlname: still_public_page.urlname }
           expect(response).to be_successful
         end
       end
@@ -216,7 +216,7 @@ module Alchemy
         end
 
         it "renders page" do
-          get :show, params: {urlname: still_public_page.urlname}
+          get :show, params: { urlname: still_public_page.urlname }
           expect(response).to be_successful
         end
       end
@@ -225,28 +225,28 @@ module Alchemy
         render_views
 
         it "should render a rss feed" do
-          get :show, params: {urlname: page.urlname, format: :rss}
+          get :show, params: { urlname: page.urlname, format: :rss }
           expect(response.media_type).to eq("application/rss+xml")
         end
 
         it "should include content" do
           page.elements.first.content_by_name("news_headline").essence.update_columns(body: "Peters Petshop")
-          get :show, params: {urlname: "news", format: :rss}
+          get :show, params: { urlname: "news", format: :rss }
           expect(response.body).to match /Peters Petshop/
         end
       end
 
       context "requested for a page that does not contain a feed" do
         it "should render xml 404 error" do
-          get :show, params: {urlname: default_language_root.urlname, format: :rss}
+          get :show, params: { urlname: default_language_root.urlname, format: :rss }
           expect(response.status).to eq(404)
         end
       end
 
       describe "Layout rendering" do
         context "with ajax request" do
           it "should not render a layout" do
-            get :show, params: {urlname: page.urlname}, xhr: true
+            get :show, params: { urlname: page.urlname }, xhr: true
             expect(response).to render_template(:show)
             expect(response).not_to render_template(layout: "application")
           end
@@ -256,19 +256,18 @@ module Alchemy
       describe "url nesting" do
         render_views
 
-        let(:catalog)  { create(:alchemy_page, :public, name: "Catalog", urlname: "catalog", parent: default_language_root, language: default_language, visible: true) }
+        let(:catalog) { create(:alchemy_page, :public, name: "Catalog", urlname: "catalog", parent: default_language_root, language: default_language, visible: true) }
         let(:products) { create(:alchemy_page, :public, name: "Products", urlname: "products", parent: catalog, language: default_language, visible: true) }
-        let(:product)  { create(:alchemy_page, :public, name: "Screwdriver", urlname: "screwdriver", parent: products, language: default_language, autogenerate_elements: true, visible: true) }
+        let(:product) { create(:alchemy_page, :public, name: "Screwdriver", urlname: "screwdriver", parent: products, language: default_language, autogenerate_elements: true, visible: true) }
 
         before do
           allow(Alchemy.user_class).to receive(:admins).and_return(OpenStruct.new(count: 1))
-          stub_alchemy_config(:url_nesting, true)
           product.elements.find_by_name("article").contents.essence_texts.first.essence.update_column(:body, "screwdriver")
         end
 
         context "with correct levelnames in params" do
           it "should show the requested page" do
-            get :show, params: {urlname: "catalog/products/screwdriver"}
+            get :show, params: { urlname: "catalog/products/screwdriver" }
             expect(response.status).to eq(200)
             expect(response.body).to have_content("screwdriver")
           end
@@ -277,7 +276,7 @@ module Alchemy
         context "with incorrect levelnames in params" do
           it "should render a 404 page" do
             expect {
-              get :show, params: {urlname: "catalog/faqs/screwdriver"}
+              get :show, params: { urlname: "catalog/faqs/screwdriver" }
             }.to raise_error(ActionController::RoutingError)
           end
         end
@@ -286,7 +285,7 @@ module Alchemy
       context "when a non-existent page is requested" do
         it "should rescue a RoutingError with rendering a 404 page." do
           expect {
-            get :show, params: {urlname: "doesntexist"}
+            get :show, params: { urlname: "doesntexist" }
           }.to raise_error(ActionController::RoutingError)
         end
       end
@@ -299,12 +298,12 @@ module Alchemy
 
           context "with no lang parameter present" do
             it "should store defaults language id in the session." do
-              get :show, params: {urlname: page.urlname}
+              get :show, params: { urlname: page.urlname }
               expect(controller.session[:alchemy_language_id]).to eq(Language.default.id)
             end
 
             it "should store default language as class var." do
-              get :show, params: {urlname: page.urlname}
+              get :show, params: { urlname: page.urlname }
               expect(Language.current).to eq(Language.default)
             end
           end
@@ -326,7 +325,7 @@ module Alchemy
           end
 
           it "renders the page related to its language" do
-            get :show, params: {urlname: "same-name", locale: klingon_page.language_code}
+            get :show, params: { urlname: "same-name", locale: klingon_page.language_code }
             expect(response.body).to have_content("klingon page")
           end
         end

spec/helpers/alchemy/pages_helper_spec.rb

@@ -4,14 +4,13 @@
 
 module Alchemy
   describe PagesHelper do
-    let(:language_root)            { create(:alchemy_page, :language_root) }
-    let(:public_page)              { create(:alchemy_page, :public) }
-    let(:klingon)                  { create(:alchemy_language, :klingon) }
-    let(:klingon_language_root)    { create(:alchemy_page, :language_root, language: klingon) }
+    let(:language_root) { create(:alchemy_page, :language_root) }
+    let(:public_page) { create(:alchemy_page, :public) }
+    let(:klingon) { create(:alchemy_language, :klingon) }
+    let(:klingon_language_root) { create(:alchemy_page, :language_root, language: klingon) }
 
     before do
       helper.controller.class_eval { include Alchemy::ConfigurationMethods }
-      allow(Config).to receive(:get) { |arg| arg == :url_nesting ? true : Config.parameter(arg) }
       @root_page = language_root # We need this instance variable in the helpers
     end
 
@@ -92,8 +91,8 @@ module Alchemy
 
     describe "#render_breadcrumb" do
       let(:parent) { create(:alchemy_page, :public, visible: true) }
-      let(:page)   { create(:alchemy_page, :public, parent_id: parent.id, visible: true) }
-      let(:user)   { nil }
+      let(:page) { create(:alchemy_page, :public, parent_id: parent.id, visible: true) }
+      let(:user) { nil }
 
       before do
         allow(helper).to receive(:multi_language?).and_return(false)