Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add errors when node cant be deleted #1828

Merged
merged 2 commits into from
May 13, 2020
Merged

Add errors when node cant be deleted #1828

merged 2 commits into from
May 13, 2020

Commits on May 13, 2020

  1. Add error before destroying node with attached essence 

    Nodes that are used on e.g. content pages can not be simply destroyed.
This commit adds an error message so the user knows what's going on.
    @mamhoff
    mamhoff committed May 13, 2020
    Configuration menu
    Copy the full SHA
    27480a2 View commit details
    Browse the repository at this point in the history

  2. Do not destroy nodes with dependent nodes that are in use on a page 

    This moves the validation up in the file so that awesome_nested_set does
not run its `delete_all` callback before we validate that it can do
that.

It also extends the validation such that we collect all the pages that
are referenced in the subtree below this node.
    @mamhoff
    mamhoff committed May 13, 2020
    Configuration menu
    Copy the full SHA
    bacc74f View commit details
    Browse the repository at this point in the history