Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Boarding Flow #1770

Merged
merged 13 commits into from
Apr 3, 2020
Merged

On Boarding Flow #1770

merged 13 commits into from
Apr 3, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 31, 2020

What is this pull request for?

Ads an on boarding flow that redirects to the sites admin if no site is present yet and redirects to languages admin after creating a site as well as redirecting to the pages admin after creating a language.

Screenshots

Onboarding - No sites

Onboarding - No language

Onboarding - No menus

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

We will add more functionality to that module
We do not need to test for any language to be present if we load the current language and only redirect to the new language form if that is missing.
Since we do not automatically create new sites implicitely this will help onboarding new users.
Now that we do not implicitely create the default language anymore this will help onboarding new users.
A site needs languages. To better onboard new users we should redirect to the language admin after creating a new site (that does not have any languages yet REMOVE ME)
We want to see links in hints
We would either lose lots of data or orphaned records.
We must not delete a language if there are still pages present. We either would lose a lot of data or orphaned records.
@tvdeyen tvdeyen added this to the 5.0 milestone Mar 31, 2020
@alexanderadam
Copy link
Contributor

Nice! I also thought that this would be nice when I came to Alchemy first. But somehow I forgot about it. 😉

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tvdeyen tvdeyen merged commit 8531f6c into AlchemyCMS:master Apr 3, 2020
@tvdeyen tvdeyen deleted the onboarding branch April 3, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants