Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit Site and Language creation #1763

Merged
merged 29 commits into from
Mar 30, 2020
Merged

Remove implicit Site and Language creation #1763

merged 29 commits into from
Mar 30, 2020

Commits on Mar 29, 2020

  1. Remove implicit Site creation 

    We do not want to implicitly create a site when none is there. This
should be in control of the admin user.
    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    c83f915 View commit details
    Browse the repository at this point in the history

  2. Make current site and current language ID optional in controllers

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    f132472 View commit details
    Browse the repository at this point in the history

  3. Fix factories to not rely on implicit site/language creation 

    - Fix language factory to not rely on implicit Site creation

- Create Site and Language in Node Factory

- Page Factory: Ensure no additional language is created
    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    3ac4a15 View commit details
    Browse the repository at this point in the history

  4. Fix Language spec to not rely on implicit language creation

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    604c247 View commit details
    Browse the repository at this point in the history

  5. Add early return to BaseHelper#page_or_find 

    This should inform devs to create a language if necessary.
    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    4622f9c View commit details
    Browse the repository at this point in the history

  6. Fix Pages Helper spec to use German instead of English 

    Implicitly, this was English, but explicitly, our language factory now
makes a German language.
    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    94bf355 View commit details
    Browse the repository at this point in the history

  7. Fix Controller Actions Spec

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    2dafd79 View commit details
    Browse the repository at this point in the history

  8. Fix Page Layout library spec

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    ac924e4 View commit details
    Browse the repository at this point in the history

  9. Use safe navigation in needs_redirect_to_primary_host

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    d3e714b View commit details
    Browse the repository at this point in the history

  10. Create Language before Metadata view spec

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    45e7c32 View commit details
    Browse the repository at this point in the history

  11. Add Site and Language creation to seeder

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    2e50a5f View commit details
    Browse the repository at this point in the history

  12. Do not raise in basecontroller 

    If no current language is present, simply do not set `I18n.locale`.
    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    c6137c1 View commit details
    Browse the repository at this point in the history

  13. Make sure test setup happens in node spec

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    971e103 View commit details
    Browse the repository at this point in the history

  14. Fix page spec

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    242e390 View commit details
    Browse the repository at this point in the history

  15. Fix request specs

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    70671f6 View commit details
    Browse the repository at this point in the history

  16. Fix prefix_locale and add a spec

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    014bf08 View commit details
    Browse the repository at this point in the history

  17. Needs specs, don't fail if no current language

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    00ece06 View commit details
    Browse the repository at this point in the history

  18. Refactor Admin Pages Controller to deal with no root pages 

    I needed to move authorization up in order to add the right redirect for
the case when no language is present.
    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    b472a82 View commit details
    Browse the repository at this point in the history

  19. Fix Base Controller to rely on actual data rather than mocks

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    be2862b View commit details
    Browse the repository at this point in the history

  20. Fix Alchemy Layoutpages Controller 

    This was tricky, as the request store is not emptied out between test
runs :(.
    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    a16ee99 View commit details
    Browse the repository at this point in the history

  21. Fix ApiController#show to not break without a language

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    d2744ff View commit details
    Browse the repository at this point in the history

  22. Fix Pages Controller

    @mamhoff
    mamhoff committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    3c744d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Redirect to sites if no sites present.

    @mamhoff
    mamhoff committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    1c88f53 View commit details
    Browse the repository at this point in the history

  2. Fix Languages Admin Feature Spec 

    The redirect feature is already tested at the controller level.
    @mamhoff
    mamhoff committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    93c10e0 View commit details
    Browse the repository at this point in the history

  3. Fix Page Redirects spec

    @mamhoff
    mamhoff committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    ca042df View commit details
    Browse the repository at this point in the history

  4. Redirect to Sites if navigating to Menu Admin without Site

    @mamhoff
    mamhoff committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    aff7903 View commit details
    Browse the repository at this point in the history

  5. Fix Page Navigation feature spec 

    We need a page, otherwise we won't be able to navigate to the menus
admin as an Editor.
    @mamhoff
    mamhoff committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    f297dcb View commit details
    Browse the repository at this point in the history

  6. Create language in pages feature spec 

    The redirecting is tested at the controller level.
    @mamhoff
    mamhoff committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    f96820c View commit details
    Browse the repository at this point in the history

  7. Refactor Bootstrapping Redirects into concerns 

    This should alleviate some of CodeClimate's concerns.
    @mamhoff
    mamhoff committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    669943d View commit details
    Browse the repository at this point in the history