-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove implicit Site and Language creation #1763
Remove implicit Site and Language creation #1763
Commits on Mar 29, 2020
-
We do not want to implicitly create a site when none is there. This should be in control of the admin user.
Configuration menu - View commit details
-
Copy full SHA for c83f915 - Browse repository at this point
Copy the full SHA c83f915View commit details -
Configuration menu - View commit details
-
Copy full SHA for f132472 - Browse repository at this point
Copy the full SHA f132472View commit details -
Fix factories to not rely on implicit site/language creation
- Fix language factory to not rely on implicit Site creation - Create Site and Language in Node Factory - Page Factory: Ensure no additional language is created
Configuration menu - View commit details
-
Copy full SHA for 3ac4a15 - Browse repository at this point
Copy the full SHA 3ac4a15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 604c247 - Browse repository at this point
Copy the full SHA 604c247View commit details -
Add early return to
BaseHelper#page_or_find
This should inform devs to create a language if necessary.
Configuration menu - View commit details
-
Copy full SHA for 4622f9c - Browse repository at this point
Copy the full SHA 4622f9cView commit details -
Fix Pages Helper spec to use German instead of English
Implicitly, this was English, but explicitly, our language factory now makes a German language.
Configuration menu - View commit details
-
Copy full SHA for 94bf355 - Browse repository at this point
Copy the full SHA 94bf355View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dafd79 - Browse repository at this point
Copy the full SHA 2dafd79View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac924e4 - Browse repository at this point
Copy the full SHA ac924e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3e714b - Browse repository at this point
Copy the full SHA d3e714bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45e7c32 - Browse repository at this point
Copy the full SHA 45e7c32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e50a5f - Browse repository at this point
Copy the full SHA 2e50a5fView commit details -
Do not raise in basecontroller
If no current language is present, simply do not set `I18n.locale`.
Configuration menu - View commit details
-
Copy full SHA for c6137c1 - Browse repository at this point
Copy the full SHA c6137c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 971e103 - Browse repository at this point
Copy the full SHA 971e103View commit details -
Configuration menu - View commit details
-
Copy full SHA for 242e390 - Browse repository at this point
Copy the full SHA 242e390View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70671f6 - Browse repository at this point
Copy the full SHA 70671f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 014bf08 - Browse repository at this point
Copy the full SHA 014bf08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00ece06 - Browse repository at this point
Copy the full SHA 00ece06View commit details -
Refactor Admin Pages Controller to deal with no root pages
I needed to move authorization up in order to add the right redirect for the case when no language is present.
Configuration menu - View commit details
-
Copy full SHA for b472a82 - Browse repository at this point
Copy the full SHA b472a82View commit details -
Configuration menu - View commit details
-
Copy full SHA for be2862b - Browse repository at this point
Copy the full SHA be2862bView commit details -
Fix Alchemy Layoutpages Controller
This was tricky, as the request store is not emptied out between test runs :(.
Configuration menu - View commit details
-
Copy full SHA for a16ee99 - Browse repository at this point
Copy the full SHA a16ee99View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2744ff - Browse repository at this point
Copy the full SHA d2744ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c744d3 - Browse repository at this point
Copy the full SHA 3c744d3View commit details
Commits on Mar 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1c88f53 - Browse repository at this point
Copy the full SHA 1c88f53View commit details -
Fix Languages Admin Feature Spec
The redirect feature is already tested at the controller level.
Configuration menu - View commit details
-
Copy full SHA for 93c10e0 - Browse repository at this point
Copy the full SHA 93c10e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca042df - Browse repository at this point
Copy the full SHA ca042dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for aff7903 - Browse repository at this point
Copy the full SHA aff7903View commit details -
Fix Page Navigation feature spec
We need a page, otherwise we won't be able to navigate to the menus admin as an Editor.
Configuration menu - View commit details
-
Copy full SHA for f297dcb - Browse repository at this point
Copy the full SHA f297dcbView commit details -
Create language in pages feature spec
The redirecting is tested at the controller level.
Configuration menu - View commit details
-
Copy full SHA for f96820c - Browse repository at this point
Copy the full SHA f96820cView commit details -
Refactor Bootstrapping Redirects into concerns
This should alleviate some of CodeClimate's concerns.
Configuration menu - View commit details
-
Copy full SHA for 669943d - Browse repository at this point
Copy the full SHA 669943dView commit details