Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop #1753

Merged
merged 15 commits into from
Mar 18, 2020
Merged

Update rubocop #1753

merged 15 commits into from
Mar 18, 2020

Commits on Mar 18, 2020

  1. Fix all Rubocop offences 

    Done with `bundle exec rubocop -a` and fixed one issue manually.
    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    56f81d8 View commit details
    Browse the repository at this point in the history

  2. Update Rubocop to 0.80.1

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    47e3593 View commit details
    Browse the repository at this point in the history

  3. Run Layout/EmptyLineAfterGuardClause cop -a

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    d9f505f View commit details
    Browse the repository at this point in the history

  4. Run Lint/SendWithMixinArgument cop -a

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    f254bba View commit details
    Browse the repository at this point in the history

  5. Fix false negative rubocop in factories 

    The public attribute is not the public keyword.
    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    b2d7e4d View commit details
    Browse the repository at this point in the history

  6. Run Style/RedundantReturn cop -a

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    b6d9401 View commit details
    Browse the repository at this point in the history

  7. Disable Layout/RescueEnsureAlignment

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    8d649dc View commit details
    Browse the repository at this point in the history

  8. Fix Style/MultilineWhenThen

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    a7f4faf View commit details
    Browse the repository at this point in the history

  9. Fix Lint/RedundantStringCoercion

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    c114fcc View commit details
    Browse the repository at this point in the history

  10. Fix Lint/NonDeterministicRequireOrder

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    68fbeeb View commit details
    Browse the repository at this point in the history

  11. Use default Layout/HeredocIndentation config

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    5a88647 View commit details
    Browse the repository at this point in the history

  12. Fix Naming/RescuedExceptionsVariableName cop -a

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    4b41906 View commit details
    Browse the repository at this point in the history

  13. Fix Style/FloatDivision

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    cb6587b View commit details
    Browse the repository at this point in the history

  14. Ensure HoundCI uses same Rubocop version as we

    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    6539f2f View commit details
    Browse the repository at this point in the history

  15. Refactor shell colors 

    To not use a String to constantize anymore.
    @tvdeyen
    tvdeyen committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    3f13d96 View commit details
    Browse the repository at this point in the history