Sortable resources tables #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we where relying on the default sort order of the database. That is, but does not have to be, the primary column in most databases. This changes this behavior to introduce a default_sort_order that uses the name column (if the resource has one) or the first attribute in an ascending sort order. Also adds a nice little indicator to the sorted column.
tvdeyen
force-pushed
the
sortable-resources-tables
branch
from
9065e36
to
9d88ed8
Compare
tvdeyen
force-pushed
the
sortable-resources-tables
branch
from
9d88ed8
to
7cdfdc3
Compare
tvdeyen
force-pushed
the
sortable-resources-tables
branch
from
485c921
to
8ad0674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Add default sort order to resources tables.
Notable changes
Before we where relying on the default sort order of the database. That is, but does not have to be, the primary column in most databases.
This changes this behavior to introduce a
default_sort_orderthat uses thenamecolumn (if the resource has one) or the first attribute in an ascending sort order.Also adds a nice little indicator to the sorted column.
Screenshots