Fallback to default local if unavailable locale requested #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where a user's browser or an out-of-date session request a locale that the current app is not able to serve, set session and locale to the default locale of the app.
|
The failing spec seems to be unrelated? |
tvdeyen
approved these changes
Aug 13, 2019
tvdeyen
added a commit
that referenced
this pull request
Aug 13, 2019
tvdeyen
added a commit
that referenced
this pull request
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
If an app that uses Alchemy has it's
::I18n.available_localesarray restricted to only a few locales, but the user's browser or a stale:alchemy_localesession value request one that is not listed as available, set the session to the default locale.In cases where the app has
enforce_available_localeset to `true, the previous behaviour would raise an error - which would make Alchemy unusable because of an unavailable locale.