Only return visible elements from Pages elements relations #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 17, 2019
tvdeyen
force-pushed
the
page-elements-always-available-only
branch
from
e1b0dd1
to
461462f
Compare
We have scopes on the page.elements relation that makes it impossible to get all elements from a page.
Instead of using the page.elements relation that is meant to be used by frontend devs and rely on that relation to never change we use explicit scopes to load exactly the elements we need in the admin.
These two relations were only used in one method. We can create the necessary query in that method instead.
This relation was only used in two internal methods and was never meant to be public API.
We already only return untrashed elements from these relations. It does not make sense to include unvisible elements. Refs AlchemyCMS#1587
The available scope is the default scope for Pages elements relation.
The available scope is now the default scope for Pages elements relation.
tvdeyen
force-pushed
the
page-elements-always-available-only
branch
from
461462f
to
ec6a844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Only return visible elements from
Pageselementsandfixed_elementsrelations.Before we only return not trashed elements, but as discussed in #1587 is is very confusing to have hidden elements returned as well.
Refs #1587
Notable changes
This now always return not-trashed and visible elements from
page.elementscalls. If - for any reason - you want to have all elements (even trashed and invisible elements) you have to use the newly introducedall_elementsrelation.