Render new page when there is a flash message #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afdev82 Hi, as discussed earlier, this is the PR that fixes the flash messages. Do you have anything to add to it? |
|
Fine for me 👍 |
tvdeyen
requested changes
Jan 7, 2019
Never render a cached version of a page if there is a flash message.
tvdeyen
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old page
What is this pull request for?
When you have flash messages in place this is needed so that flash messages do not get cached and re-rendered when from cache, otherwise the flash message keeps displaying even though there was no flash message in a new request.