Fixes picture per page in overlay #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
fixes-picture-per-page
branch
from
db2af65
to
7733bfa
Compare
houndci-bot
reviewed
Sep 20, 2018
| else | ||
| cookies[:alchemy_pictures_per_page] = params[:per_page] || | ||
| cookies[:alchemy_pictures_per_page] || | ||
| pictures_per_page_for_size(params[:size]) |
There was a problem hiding this comment.
Layout/MultilineOperationIndentation: Align the operands of an expression in an assignment spanning multiple lines.
| end | ||
| else | ||
| cookies[:alchemy_pictures_per_page] = params[:per_page] || | ||
| cookies[:alchemy_pictures_per_page] || |
There was a problem hiding this comment.
Layout/MultilineOperationIndentation: Align the operands of an expression in an assignment spanning multiple lines.
tvdeyen
force-pushed
the
fixes-picture-per-page
branch
from
7733bfa
to
0199d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Fixes picture per page value in picture assignment overlay
Notable changes
The cookie that stores the pictures per page value for the picture library must not be used in the overlay.