Fix tidy task #1449
Merged
Fix tidy task #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes possible duplicate folded pages as part of the tidy task, in order to provide a smoother upgrade path.
With nested elements, we might have orphaned elements with nested elements or elements with orphaned nested elements. This change reloads the record in question in order to make sure it is still there. If not, the reload will return `nil`, and nothing terrible happens.
tvdeyen
approved these changes
May 18, 2018
This was referenced May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This should fix the tidy task issues #1432 and #1433 .
Notable changes (remove if none)
Adds another task for the folded pages, and reloads every record that is to be deleted.
This makes the task a littler slower, but safer: Afterwards, the migration that adds foreign keys and things runs through without issues.