Move translations into extension #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
remove-rails-translations
branch
2 times, most recently
from
dcfceb2
to
40d4c8f
Compare
Closed
tvdeyen
force-pushed
the
remove-rails-translations
branch
from
40d4c8f
to
4105773
Compare
tvdeyen
force-pushed
the
remove-rails-translations
branch
from
4105773
to
b8d1f09
Compare
houndci-bot
reviewed
Apr 3, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
houndci-bot
reviewed
Apr 3, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
The default localization of `Time`s `date` format differs in each Rails app. We should have our own date format for `EssenceDate`.
Adds new `time_format` and `datetime_format` options for rendering resources. Defaults to `alchemy.default` and `alchenm.time`
To bring them back into your app you need to either add the `rails-i18n` gem or - recommended - copy the Rails locale file of the locales you support into your apps `config/locales` folder.
In order to provide alchemy translations in other gems as well we use the `I18n.load_path` to get all Alchemy translations.
Move the translation files from here into the new `alchemy_i18n` gem. If you need more translations than the default english one you can either put `alchemey_i18n` to your apps `Gemfile` or - recommended - copy the translation files you need into your apps locales folder. The translation files can be found at https://github.com/AlchemyCMS/alchemy_i18n/tree/master/config/locales.
This feature spec expects that translation files are actually present. Instead it should just test what it actually does: Setting `I18n.lcoale` and store it in the session.
Add latest simple form config and keep our changes.
Move them into the newly introduced `alchemy_i18n` gem.
You need to require the select2 locale you want to use explicitly in your `vendor/assets/alchemy/admin/all.js` file ```js //= require select2_locale_de //= require select2_locale_es ```
tvdeyen
force-pushed
the
remove-rails-translations
branch
from
2028a15
to
71a0aaa
Compare
houndci-bot
reviewed
Apr 3, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
1. Includes available locales from multiple sources only once 2. Supports long locale names (ie. zh-CN) 3. Sorts the output
In order to be able to push the default English translation to localeapp.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Rails translations from our translation files and introduces some new localisation scopes for time and date values.
Also moves all non-english translation files into the newly introduced
alchemy_i18ngemGet back Alchemy translations
If you need more translations than the default English one you can either put
alchemy_i18nin to your appsGemfileor - recommended - copy only the translation files you need into your appsconfig/localesfolder.Get back the Rails translations
Either put the
rails-i18ngem into your appsGemfileor - recommended - copy only the translation files you need into your appsconfig/localesfolder.Closes #1345
TODO
alchemy_i18nto READMEalchemy_i18nalchemy_i18nalchemy_i18nselect2translationsdevisetranslations fromalchemy-devisealchemytranslations fromalchemy-deviseintoalchemy_i18n