-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move translations into extension #1398
Move translations into extension #1398
Conversation
dcfceb2
to
40d4c8f
Compare
40d4c8f
to
4105773
Compare
4105773
to
b8d1f09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
The default localization of `Time`s `date` format differs in each Rails app. We should have our own date format for `EssenceDate`.
Adds new `time_format` and `datetime_format` options for rendering resources. Defaults to `alchemy.default` and `alchenm.time`
To bring them back into your app you need to either add the `rails-i18n` gem or - recommended - copy the Rails locale file of the locales you support into your apps `config/locales` folder.
In order to provide alchemy translations in other gems as well we use the `I18n.load_path` to get all Alchemy translations.
Move the translation files from here into the new `alchemy_i18n` gem. If you need more translations than the default english one you can either put `alchemey_i18n` to your apps `Gemfile` or - recommended - copy the translation files you need into your apps locales folder. The translation files can be found at https://github.com/AlchemyCMS/alchemy_i18n/tree/master/config/locales.
This feature spec expects that translation files are actually present. Instead it should just test what it actually does: Setting `I18n.lcoale` and store it in the session.
Add latest simple form config and keep our changes.
Move them into the newly introduced `alchemy_i18n` gem.
You need to require the select2 locale you want to use explicitly in your `vendor/assets/alchemy/admin/all.js` file ```js //= require select2_locale_de //= require select2_locale_es ```
2028a15
to
71a0aaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
1. Includes available locales from multiple sources only once 2. Supports long locale names (ie. zh-CN) 3. Sorts the output
In order to be able to push the default English translation to localeapp.com
Removes the Rails translations from our translation files and introduces some new localisation scopes for time and date values.
Also moves all non-english translation files into the newly introduced
alchemy_i18n
gemGet back Alchemy translations
If you need more translations than the default English one you can either put
alchemy_i18n
in to your appsGemfile
or - recommended - copy only the translation files you need into your appsconfig/locales
folder.Get back the Rails translations
Either put the
rails-i18n
gem into your appsGemfile
or - recommended - copy only the translation files you need into your appsconfig/locales
folder.Closes #1345
TODO
alchemy_i18n
to READMEalchemy_i18n
alchemy_i18n
alchemy_i18n
select2
translationsdevise
translations fromalchemy-devise
alchemy
translations fromalchemy-devise
intoalchemy_i18n