Use Gutentag for tags #1364
Merged
Use Gutentag for tags #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 26, 2018
lib/alchemy/taggable.rb
Outdated
| # Returns all unique tags | ||
| def tag_counts | ||
| Gutentag::Tag.distinct.joins(:taggings) | ||
| .where(gutentag_taggings: {taggable_type: self.name}) |
tvdeyen
force-pushed
the
migrate-to-gutentag
branch
2 times, most recently
from
776868b
to
9fa456b
Compare
This module handles all tag related stuff for our models.
tvdeyen
force-pushed
the
migrate-to-gutentag
branch
from
9fa456b
to
5a46220
Compare
Gutentag is a small but capable library for managing tags in activerecord models. ActsAsTaggableOn is full of features we don't use and not very well maintained lately. It also lacks support for Rails 5.2
Since the acts-as-taggable-on migrations make use of the ActsAsTaggableOn class, we want to skip the tasks inside of these migrations. We renamed the tables anyway, but in order to be able to re-run these migrations without harm it makes sense to skip these migrations.
tvdeyen
force-pushed
the
migrate-to-gutentag
branch
from
5a46220
to
daa312f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutentag is a small but capable library for managing tags in activerecord models.
ActsAsTaggableOn is full of features we don't use and not very well maintained.
It also lacks support for Rails 5.2