-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New color theme #1352
Merged
Merged
New color theme #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
light-color-theme
branch
3 times, most recently
from
January 23, 2018 18:26
85391a0
to
d34be58
Compare
tvdeyen
force-pushed
the
light-color-theme
branch
2 times, most recently
from
February 27, 2018 13:59
241a0a7
to
8c45758
Compare
We have our own styles for buttons and links. We want the jquery ui widgets (mainly the tabbed windows and cells body) inherit the style.
Introduces a new dark blue color, that will play a mayor role in the new UI as the primary color.
The Sass mixin for button was also used for selects. With the new button style this doesn't work anymore. As selects are more inputs than buttons we update the button mixin and adjust the select and input styles.
For secondary buttons, like the cancel button in confirm dialogs, we introduce a new secondary button style.
The former focus color was using the blue color variable. Introducing a focus color variable and set this to a orange color to provide a nice contrast to the dark blue button color.
Using a dark shade of the new primary blue color for the left menu adds more visual importance to the content.
Using the new dark blur primary color to give the dialog headers some meaning and better fit with the new blur primary button.
Removes the button lookalike and uses the fontawesome icons.
Use a white spinner on a dark blue background.
After adjusting the focus style we need to adjust the sitemap highlighted and selected styles.
Adjust the linked button styles to fit the new button styles
Fits the current primary color
Adds some more dialog Sass variables, so we can reuse them for TinyMCE dialogs
And add some more variables, so we can use them for styling TinyMCE input fields as well.
Adjust the TinyMCE styles to new color theme.
Sass seems not to be able to pick the :not() selector in conjunction with the & rule extender.
Adds even more contrast between active pages, the body and the top menu
The background was not spaning the whole dialog bod because of clearing issues.
By adding you own custom variables file you are able to overwrite the Alchemy admin skin
tvdeyen
force-pushed
the
light-color-theme
branch
from
February 28, 2018 10:26
ee0e973
to
61b0013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we changed to monochrome icons we lost some contrast.