Fixes admin content creation js response #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
fixes-missing-content-creation
branch
from
d963a81
to
198a153
Compare
Rails 5.1 does not support `symbolize_keys` of params anymore. With the changes we made to `options_from_params` we do not need to convert the keys anymore as the params hash already has indifferent access.
tvdeyen
force-pushed
the
fixes-missing-content-creation
branch
from
198a153
to
0b56676
Compare
mamhoff
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.1 does not support
symbolize_keysof params anymore. With thechanges we made to
options_from_paramswe do not need to convert the keysanymore as the params hash already has indifferent access.