Handle custom errors in Alchemy::Picture#url #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
handle-picture-errors
branch
from
3c91cb8
to
58c8f03
Compare
When using log_warning to log a warning to Rails logger we pass the line of the caller. As the instance method delegates to the class method we need to use the second line of the callstack.
Currently we raise custom errors in the Alchemy::Picture#url method without rescueing them later. This causes pages and the image library to fail completely if one the images could not be rendered because the image file is missing or the image format could not be used. This is bad user experience. We should not display the broken image and not break the whole page.
tvdeyen
force-pushed
the
handle-picture-errors
branch
from
58c8f03
to
4dd2496
Compare
mamhoff
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we raise custom errors in the Alchemy::Picture#url
method without rescueing them later. This causes pages and the image library
to fail completely if one the images could not be rendered because the image file
is missing or the image format could not be used.
This is bad user experience. We should not display the broken image and not break the whole page.