Fix Style/FloatDivision

AlchemyCMS · Mar 18, 2020 · cb6587b · cb6587b
1 parent 4b41906
commit cb6587b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -21,6 +21,9 @@ Style/EmptyLiteral:
 Style/ClassVars:
   Enabled: false
 
+Style/FloatDivision:
+  EnforcedStyle: left_coerce
+
 # This has been used for customization
 Style/MutableConstant:
   Enabled: false

diff --git a/app/controllers/alchemy/admin/essence_pictures_controller.rb b/app/controllers/alchemy/admin/essence_pictures_controller.rb
@@ -87,7 +87,7 @@ def ratio_from_size_or_settings
         if @min_size.value?(0) && @essence_picture.content.settings[:fixed_ratio].to_s =~ FLOAT_REGEX
           @essence_picture.content.settings[:fixed_ratio].to_f
         elsif !@min_size[:width].zero? && !@min_size[:height].zero?
-          @min_size[:width].to_f / @min_size[:height].to_f
+          @min_size[:width].to_f / @min_size[:height]
         else
           false
         end