Merge pull request #1442 from tvdeyen/update-check-fix

Use max instead of sort.last in update check

app/controllers/alchemy/admin/dashboard_controller.rb

@@ -44,7 +44,7 @@ def latest_alchemy_version
         return '' if versions.blank?
         # reject any non release version
         versions.reject! { |v| v =~ /[a-z]/ }
-        versions.sort.last
+        versions.max
       end
 
       # Get alchemy versions from rubygems or github, if rubygems failes.

spec/controllers/alchemy/admin/dashboard_controller_spec.rb

@@ -92,10 +92,12 @@ module Alchemy
       end
 
       context "if current Alchemy version is older than latest released version" do
-        before {
-          allow(controller).to receive(:latest_alchemy_version).and_return('2.6')
+        before do
+          allow_any_instance_of(Net::HTTP).to receive(:request) do
+            OpenStruct.new({code: '200', body: '[{"number": "2.6"}, {"number": "2.5"}]'})
+          end
           allow(Alchemy).to receive(:version).and_return("2.5")
-        }
+        end
 
         it "should render 'true'" do
           get :update_check