Skip to content

Commit

Permalink
fix(RoutingConstraints): Allow Turbo Stream requests
Browse files Browse the repository at this point in the history
`rails-turbo` [registers a new request format](https://github.com/hotwired/turbo-rails/blob/e376852bfb273f69f4ebb54cf516b99fcbaa7acb/lib/turbo/engine.rb#L82-L89)

    text/vnd.turbo-stream.html

which is used whenever Turbo redirects.

In order to handle those requests from - for example the messages controller -
we need to allow this mime type to route into Alchemy as well.
  • Loading branch information
tvdeyen committed Jun 4, 2024
1 parent 294faa5 commit 772a151
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/alchemy/routing_constraints.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def matches?(request)
# because it could be a legacy route that needs to be redirected.
#
def handable_format?
@request.format.symbol.nil? || (@request.format.symbol == :html)
@request.format.symbol.nil? || @request.format.html?
end

# We don't want to handle the Rails info routes.
Expand Down
8 changes: 8 additions & 0 deletions spec/routing/routing_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,14 @@
end
end

describe "Turbo stream requests" do
it do
expect({
get: "/contact/thanks.turbo_stream"
}).to be_routable
end
end

context "for admin interface" do
context "default" do
it "should route to admin dashboard" do
Expand Down

0 comments on commit 772a151

Please sign in to comment.