Remove Site ID from nodes

Nodes can get their Site through their language.

app/models/alchemy/node.rb

@@ -7,7 +7,6 @@ class Node < BaseRecord
     acts_as_nested_set scope: 'language_id', touch: true
     stampable stamper_class_name: Alchemy.user_class_name
 
-    belongs_to :site, class_name: 'Alchemy::Site'
     belongs_to :language, class_name: 'Alchemy::Language'
     belongs_to :page, class_name: 'Alchemy::Page', optional: true, inverse_of: :nodes
 

db/migrate/20200504210159_remove_site_id_from_nodes.rb

@@ -0,0 +1,12 @@
+class RemoveSiteIdFromNodes < ActiveRecord::Migration[6.0]
+  def up
+    remove_index :alchemy_nodes, :site_id
+    remove_column :alchemy_nodes, :site_id, :integer, null: false
+  end
+
+  def down
+    # This IS, in fact, reversible - but it's cumbersome to do. If someone tells me it benefits them
+    # I will implement.
+    raise ActiveRecord::IrreversibleMigration
+  end
+end

spec/dummy/db/migrate/20200504210159_remove_site_id_from_nodes.rb

@@ -0,0 +1,12 @@
+class RemoveSiteIdFromNodes < ActiveRecord::Migration[6.0]
+  def up
+    remove_index :alchemy_nodes, :site_id
+    remove_column :alchemy_nodes, :site_id, :integer, null: false
+  end
+
+  def down
+    # This IS, in fact, reversible - but it's cumbersome to do. If someone tells me it benefits them
+    # I will implement.
+    raise ActiveRecord::IrreversibleMigration
+  end
+end

spec/dummy/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_02_26_213334) do
+ActiveRecord::Schema.define(version: 2020_05_04_210159) do
 
   create_table "alchemy_attachments", force: :cascade do |t|
     t.string "name"
@@ -221,14 +221,12 @@
     t.integer "updater_id"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
-    t.integer "site_id", null: false
     t.index ["creator_id"], name: "index_alchemy_nodes_on_creator_id"
     t.index ["language_id"], name: "index_alchemy_nodes_on_language_id"
     t.index ["lft"], name: "index_alchemy_nodes_on_lft"
     t.index ["page_id"], name: "index_alchemy_nodes_on_page_id"
     t.index ["parent_id"], name: "index_alchemy_nodes_on_parent_id"
     t.index ["rgt"], name: "index_alchemy_nodes_on_rgt"
-    t.index ["site_id"], name: "index_alchemy_nodes_on_site_id"
     t.index ["updater_id"], name: "index_alchemy_nodes_on_updater_id"
   end
 
@@ -363,5 +361,4 @@
   add_foreign_key "alchemy_essence_pages", "alchemy_pages", column: "page_id"
   add_foreign_key "alchemy_nodes", "alchemy_languages", column: "language_id"
   add_foreign_key "alchemy_nodes", "alchemy_pages", column: "page_id", on_delete: :cascade
-  add_foreign_key "alchemy_nodes", "alchemy_sites", column: "site_id", on_delete: :cascade
 end