-
-
Notifications
You must be signed in to change notification settings - Fork 315
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1639 from tvdeyen/add-essence-page
Add Alchemy::EssencePage
- Loading branch information
Showing
10 changed files
with
164 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# frozen_string_literal: true | ||
|
||
module Alchemy | ||
class EssencePage < BaseRecord | ||
acts_as_essence( | ||
ingredient_column: :page, | ||
preview_text_method: :name | ||
) | ||
|
||
belongs_to :page, class_name: 'Alchemy::Page', optional: true | ||
|
||
def ingredient=(page) | ||
case page | ||
when /\d/ | ||
self.page = Alchemy::Page.new(id: page) | ||
when Alchemy::Page | ||
self.page = page | ||
else | ||
super | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<div class="content_editor essence_page" id="<%= content.dom_id %>" data-content-id="<%= content.id %>"> | ||
<%= content_label(content) %> | ||
<%= select_tag( | ||
content.form_field_name, | ||
pages_for_select, | ||
id: content.form_field_id, | ||
class: 'alchemy_selectbox full_width' | ||
) %> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<% page = content.ingredient %> | ||
<% if page %> | ||
<%= link_to page.name, alchemy.show_page_path(urlname: page.urlname) %> | ||
<% end %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
class CreateAlchemyEssencePages < ActiveRecord::Migration[5.0] | ||
def change | ||
create_table :alchemy_essence_pages do |t| | ||
t.references :page, null: true, foreign_key: { to_table: :alchemy_pages } | ||
t.timestamps | ||
end | ||
end | ||
end |
10 changes: 10 additions & 0 deletions
10
lib/alchemy/test_support/factories/essence_page_factory.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'factory_bot' | ||
require 'alchemy/test_support/factories/page_factory' | ||
|
||
FactoryBot.define do | ||
factory :alchemy_essence_page, class: 'Alchemy::EssencePage' do | ||
page factory: :alchemy_page | ||
end | ||
end |
1 change: 1 addition & 0 deletions
1
spec/dummy/db/migrate/20191016073858_create_alchemy_essence_pages.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../../../db/migrate/20191016073858_create_alchemy_essence_pages.rb |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'rails_helper' | ||
|
||
RSpec.describe Alchemy::EssencePage, type: :model do | ||
let(:essence) { build(:alchemy_essence_page) } | ||
let(:page) { essence.page } | ||
|
||
it_behaves_like "an essence" do | ||
let(:ingredient_value) { page } | ||
end | ||
|
||
describe 'ingredient=' do | ||
subject(:ingredient) { essence.page } | ||
|
||
context 'when value is a String matching a number' do | ||
let(:value) { '101' } | ||
|
||
before do | ||
essence.ingredient = value | ||
end | ||
|
||
it 'sets page to an page instance with that id' do | ||
is_expected.to be_a(Alchemy::Page) | ||
expect(ingredient.id).to eq(101) | ||
end | ||
end | ||
|
||
context 'when value is an Alchemy Page' do | ||
let(:value) { page } | ||
|
||
before do | ||
essence.ingredient = value | ||
end | ||
|
||
it 'sets page to an page instance with that id' do | ||
is_expected.to be_a(Alchemy::Page) | ||
expect(ingredient).to eq(page) | ||
end | ||
end | ||
|
||
context 'when value is something else' do | ||
let(:value) { 'something' } | ||
|
||
it do | ||
expect { | ||
essence.ingredient = value | ||
}.to raise_error(ActiveRecord::AssociationTypeMismatch) | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'rails_helper' | ||
|
||
RSpec.describe 'alchemy/essences/_essence_page_editor' do | ||
let(:content) { Alchemy::Content.new(essence: essence) } | ||
let(:essence) { Alchemy::EssencePage.new } | ||
|
||
before do | ||
view.class.send(:include, Alchemy::Admin::EssencesHelper) | ||
allow(view).to receive(:content_label).and_return(content.name) | ||
end | ||
|
||
it "renders a page select box" do | ||
render 'alchemy/essences/essence_page_editor', content: content | ||
expect(rendered).to have_css('select.alchemy_selectbox.full_width') | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'rails_helper' | ||
|
||
describe 'alchemy/essences/_essence_page_view' do | ||
let(:page) { build(:alchemy_page, urlname: 'a-page') } | ||
let(:essence) { Alchemy::EssencePage.new(page: page) } | ||
let(:content) { Alchemy::Content.new(essence: essence) } | ||
|
||
context 'without page' do | ||
let(:essence) { Alchemy::EssencePage.new } | ||
|
||
it "renders nothing" do | ||
render content, content: content | ||
expect(rendered).to eq('') | ||
end | ||
end | ||
|
||
context 'with page' do | ||
it "renders a link to the page" do | ||
render content, content: content | ||
expect(rendered).to have_selector("a[href='/#{page.urlname}']") | ||
end | ||
|
||
it "has the page name as link text" do | ||
render content, content: content | ||
expect(rendered).to have_selector("a:contains('#{page.name}')") | ||
end | ||
end | ||
end |