Merge pull request #2203 from tvdeyen/switch-to-cuprite

Switch to cuprite for system testing

Gemfile

@@ -40,3 +40,8 @@ group :development, :test do
     gem "brakeman", require: false
   end
 end
+
+# Necessary for system tests in Rails 6.0
+if ENV["RAILS_VERSION"] == "6.0"
+  gem "selenium-webdriver"
+end

alchemy_cms.gemspec

@@ -57,13 +57,13 @@ Gem::Specification.new do |gem|
 
   gem.add_development_dependency "capybara", ["~> 3.0"]
   gem.add_development_dependency "capybara-screenshot", ["~> 1.0"]
+  gem.add_development_dependency "cuprite", ["~> 0.13"]
   gem.add_development_dependency "factory_bot_rails", ["~> 6.0"]
   gem.add_development_dependency "puma", ["~> 5.0"]
   gem.add_development_dependency "rails-controller-testing", ["~> 1.0"]
   gem.add_development_dependency "rspec-activemodel-mocks", ["~> 1.0"]
   gem.add_development_dependency "rspec-rails", [">= 4.0.0.beta2"]
   gem.add_development_dependency "simplecov", ["~> 0.20"]
-  gem.add_development_dependency "webdrivers", ["~> 5.0"]
   gem.add_development_dependency "webmock", ["~> 3.3"]
   gem.add_development_dependency "shoulda-matchers", ["~> 5.0"]
   gem.add_development_dependency "timecop", ["~> 0.9"]

spec/rails_helper.rb

@@ -12,7 +12,6 @@
 require "rails-controller-testing"
 require "rspec-activemodel-mocks"
 require "rspec/rails"
-require "webdrivers/chromedriver"
 require "shoulda-matchers"
 require "factory_bot"
 
@@ -47,20 +46,16 @@
 # Configure capybara for integration testing
 Capybara.default_selector = :css
 Capybara.ignore_hidden_elements = false
+Capybara.server = :puma
 
 FactoryBot.definition_file_paths.append(Alchemy::TestSupport.factories_path)
 FactoryBot.find_definitions
 
-Capybara.register_driver :selenium_chrome_headless do |app|
-  Capybara::Selenium::Driver.load_selenium
-  browser_options = ::Selenium::WebDriver::Chrome::Options.new.tap do |opts|
-    opts.args << "--headless"
-    opts.args << "--disable-gpu" if Gem.win_platform?
-    # Workaround https://bugs.chromium.org/p/chromedriver/issues/detail?id=2650&q=load&sort=-id&colspec=ID%20Status%20Pri%20Owner%20Summary
-    opts.args << "--disable-site-isolation-trials"
-    opts.args << "--window-size=1280,800"
-  end
-  Capybara::Selenium::Driver.new(app, browser: :chrome, options: browser_options)
+require "capybara/cuprite"
+Capybara.register_driver(:cuprite) do |app|
+  Capybara::Cuprite::Driver.new(app, {
+    window_size: [1280, 800],
+  })
 end
 
 Shoulda::Matchers.configure do |config|
@@ -107,6 +102,6 @@
   end
 
   config.before(:each, type: :system, js: true) do
-    driven_by :selenium_chrome_headless
+    driven_by :cuprite
   end
 end

spec/views/admin/attachments/show_spec.rb

@@ -10,7 +10,6 @@
   it "displays urls to file" do
     assign(:attachment, attachment)
     render
-    puts rendered
     aggregate_failures do
       expect(rendered).to have_selector("label:contains('URL') + p:contains('/attachment/#{attachment.id}/show')")
       expect(rendered).to have_selector("label:contains('Download-URL') + p:contains('/attachment/#{attachment.id}/download')")