-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Alchemy 7.0 #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sascha-karnatz
commented
Jul 13, 2023
•
edited
Loading
edited
- Update to Alchemy 7.0
- Update to Rails 7.0
- Remove support for essences and contents
- Use the multisearch configuration on the supported ingredients
- Fix the search for image caption (previously only the object string was stored)
- improve readability of the ingredient extension spec
- add public and upload path to gitignore - the specs are creating small images to test the picture ingredient
sascha-karnatz
force-pushed
the
update-alchemy-7
branch
from
July 13, 2023 15:18
b963885
to
19155f0
Compare
sascha-karnatz
force-pushed
the
update-alchemy-7
branch
from
July 24, 2023 07:30
e94b35d
to
781e39a
Compare
sascha-karnatz
changed the title
Draft: Improve ingredient extension
Update to Alchemy 7.0
Jul 24, 2023
tvdeyen
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
- Use the multisearch configuration on the supported ingredients - Fix the search for image caption (previously only the object string was stored) - improve readability of the ingredient extension spec - add public and upload path to gitignore - the specs are creating small images to test the picture ingredient
Update the full text search spec to use ingredients instead of essences.
update dummy app to the latest Rails version. ActiveRecord changed the implementation of first, which broke a test for the search method. I fixed it by loading the whole result. This is not a very good solution it has to be optimized in the future.
Remove all extensions for essences and contents. This will prepare the update to Alchemy 7.0, which does not support essences anymore.
Update to the latest version of Alchemy. Only newer Alchemy versions are supported. Also remove Webpacker from dummy app (which is the default in Alchemy 7.0).
Alchemy does not support Ruby versions below 3.0 and the latest version is 3.2.
sascha-karnatz
force-pushed
the
update-alchemy-7
branch
from
September 1, 2023 09:12
9f86a1e
to
d64dbac
Compare
tvdeyen
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.