Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Alchemy 7.0 #39

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Conversation

sascha-karnatz
Copy link
Contributor

@sascha-karnatz sascha-karnatz commented Jul 13, 2023

  • Update to Alchemy 7.0
  • Update to Rails 7.0
  • Remove support for essences and contents
  • Use the multisearch configuration on the supported ingredients
  • Fix the search for image caption (previously only the object string was stored)
  • improve readability of the ingredient extension spec
  • add public and upload path to gitignore - the specs are creating small images to test the picture ingredient

@sascha-karnatz sascha-karnatz changed the title Draft: Improve ingredient extension Update to Alchemy 7.0 Jul 24, 2023
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

app/extensions/alchemy/pg_search/ingredient_extension.rb Outdated Show resolved Hide resolved
spec/lib/search_spec.rb Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
lib/alchemy/pg_search/search.rb Outdated Show resolved Hide resolved
- Use the multisearch configuration on the supported ingredients
- Fix the search for image caption (previously only the object string was stored)
- improve readability of the ingredient extension spec
- add public and upload path to gitignore - the specs are creating small images to test the picture ingredient
Update the full text search spec to use ingredients instead of essences.
update dummy app to the latest Rails version. ActiveRecord changed the implementation of first, which broke a test for the search method. I fixed it by loading the whole result. This is not a very good solution it has to be optimized in the future.
Remove all extensions for essences and contents. This will prepare the update to Alchemy 7.0, which does not support essences anymore.
Update to the latest version of Alchemy. Only newer Alchemy versions are supported. Also remove Webpacker from dummy app (which is the default in Alchemy 7.0).
Alchemy does not support Ruby versions below 3.0 and the latest version is 3.2.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tvdeyen tvdeyen merged commit 1b6bafb into AlchemyCMS:main Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants