Do not convert cache duration to hours #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hours is not fine enough as granularity for good cache control. For this reason, the `Cache-Control` header operates with a granularity of seconds as well. Let's also work with seconds here. This is literally a breaking change, but it will only break caches.
mamhoff
force-pushed
the
configure-ttl-in-secondes
branch
from
2a0d06b
to
ae5602b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hours is not fine enough as granularity for good cache control. For this reason, the
Cache-Controlheader operates with a granularity of seconds as well. Let's also work with seconds here.This is literally a breaking change, but it will only break caches.