Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jsonapi.rb 2.x #75

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Allow jsonapi.rb 2.x #75

merged 2 commits into from
Feb 1, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Feb 1, 2024

In 2022, they released a new version of jsonapi.rb. The functionality almost did not change at all, so no changes on our side are necessary.

In 2022, they released a new version of jsonapi.rb. The functionality
almost did not change at all, so no changes on our side are necessary.
@mamhoff
Copy link
Contributor Author

mamhoff commented Feb 1, 2024

Duplicate

@mamhoff mamhoff closed this Feb 1, 2024
@mamhoff
Copy link
Contributor Author

mamhoff commented Feb 1, 2024

No, not a duplicate :)

@mamhoff mamhoff reopened this Feb 1, 2024
The guide says this is needed for cherry-picking just the string
extensions, and without it our specs fail.

Cf: https://guides.rubyonrails.org/active_support_core_extensions.html#loading-grouped-core-extensions
@tvdeyen tvdeyen merged commit 94c4a10 into main Feb 1, 2024
10 checks passed
@tvdeyen tvdeyen deleted the allow-jsonapi.rb-2 branch February 1, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants