Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs, bump version #6

Merged
merged 8 commits into from
Sep 15, 2020
Merged

Fix specs, bump version #6

merged 8 commits into from
Sep 15, 2020

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Sep 15, 2020

This fixes the test suite to work with recent versions of Alchemy and bumps the version to 0.2.0.

Parent Elements can use the Element serializer, of course.
Alchemy's language factory has changed a little, so this fixes things.
Node parents are nodes, thus they can use the node serializer.
Alchemy's default language factory now makes an English language, which
needs to be reflected in the spec.
Alchemy 5 got rid of the `visible` flag on pages.
Alchemy now by default creates English as a language, which is reflected
in this commit, and in order to create a layoutpage, let's use the
`:layoutpage` trait.
This gem is intended for future Alchemy versions.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@tvdeyen tvdeyen merged commit 9e5c120 into production Sep 15, 2020
@tvdeyen tvdeyen deleted the fix-specs-bump-version branch September 15, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants