Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw error if filter returns empty result #56

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 28, 2021

When a filter results in an empty result set then max_by returns nil

When a filter results in an empty result set then `max_by` returns `nil`
@tvdeyen tvdeyen requested a review from mamhoff October 28, 2021 12:18
@tvdeyen tvdeyen merged commit 503c058 into main Oct 28, 2021
@tvdeyen tvdeyen deleted the fix-error-for-empty-results branch October 28, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants